[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139198#comment-15139198
]
Christine Poerschke commented on SOLR-8621:
-------------------------------------------
Hmm, small hiccup re: {{MergePolicyFactory}}'s {{getMergePolicy}} signature.
The {{SortingMergePolicyFactory}} in SOLR-5730 needs access to the schema with
the 'obvious' signature change being
{code}
- public abstract MergePolicy getMergePolicy();
+ public abstract MergePolicy getMergePolicy(IndexSchema schema);
{code}
for the abstract {{MergePolicyFactory}} class and all classes inheriting from
it.
[~shaie] - would you have any thoughts on this? I'm thinking that changing the
signature at this point is still okay since <mergePolicyFactory> support is not
yet released and in practice {{SolrIndexConfig.buildMergePolicy(final
IndexSchema schema)}} is always able to pass the schema to the getMergePolicy
method.
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Attachments: SOLR-8621.patch, explicit-merge-auto-set.patch
>
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support
> +work-in-progress git branch:+
> [master-solr-8621|https://github.com/apache/lucene-solr/tree/master-solr-8621]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
