[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140888#comment-15140888
]
Shai Erera commented on SOLR-8621:
----------------------------------
You're right Christine, I didn't notice the {{IndexSchema}} only variant. Let's
continue on SOLR-5730 then by adding the schema to the factory's ctor.
So besides this API change, what's left to do in the context of this issue?
Since it's marked blocker for 5.5, I want to make sure that we don't hold up
the release too long:
* So the API change has to go in.
* Adding tests can be done separately? (unless you already have some work done
there).
* We finished (as far as I could tell), updating all existing solrconfig.xmls.
* We have a separate issue to remove support in 6.0.
* We should update the ref guide, but the ref guide is usually released after
the binaries anyway.
Am I missing something?
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Blocker
> Fix For: 5.5, master
>
> Attachments: SOLR-8621-example_contrib_configs.patch,
> SOLR-8621-example_contrib_configs.patch, SOLR-8621.patch,
> explicit-merge-auto-set.patch
>
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support
> +work-in-progress summary:+
> * main code changes have been committed to master and branch_5x
> * {color:red}further small code change required:{color} MergePolicyFactory
> constructor or MergePolicyFactory.getMergePolicy method to take IndexSchema
> argument (e.g. for use by SortingMergePolicyFactory being added under related
> SOLR-5730)
> * Solr Reference Guide changes (directly in Confluence?)
> * changes to remaining solrconfig.xml
> ** solr/core/src/test-files/solr/collection1/conf - Christine
> ** solr/contrib
> ** solr/example
> +open question:+
> * Do we want to error if luceneMatchVersion >= 5.5 and deprecated
> mergePolicy/mergeFactor/maxMergeDocs are used? See [~hossman]'s comment on
> Feb 1st. The code as-is permits mergePolicy irrespective of
> luceneMatchVersion, I think.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
