[ 
https://issues.apache.org/jira/browse/SOLR-8416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141508#comment-15141508
 ] 

Michael Sun commented on SOLR-8416:
-----------------------------------

Ah yes, it makes sense to skip waiting for replicas to be alive for async calls 
or in case there is failure. 

One question, it uses both rsp.getException() and 
response.getResponse().get("exception"). Are they pointing to the same 
exception? Thanks.

Also there seems a typo error that return is not included.
{code}
    if (response.getResponse().get("failure") != null) {
      // TODO: we should not wait for Replicas we know failed
    }
{code}

> The collections create API should return after all replicas are active. 
> ------------------------------------------------------------------------
>
>                 Key: SOLR-8416
>                 URL: https://issues.apache.org/jira/browse/SOLR-8416
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Michael Sun
>            Assignee: Mark Miller
>         Attachments: SOLR-8416.patch, SOLR-8416.patch, SOLR-8416.patch, 
> SOLR-8416.patch, SOLR-8416.patch, SOLR-8416.patch
>
>
> Currently the collection creation API returns once all cores are created. In 
> large cluster the cores may not be alive for some period of time after cores 
> are created. For any thing requested during that period, Solr appears 
> unstable and can return failure. Therefore it's better  the collection 
> creation API waits for all cores to become alive and returns after that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to