[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143618#comment-15143618 ]
Shai Erera commented on SOLR-8621: ---------------------------------- [~cpoerschke] these look good, so +1 to merge to 5x. I agree that we're done w/ this issue here. We can separately take care of SOLR-8674 and SOLR-8668. I enjoyed this collaboration, thank you very much for such a fun and positive experience! > solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory> > ------------------------------------------------------------------------- > > Key: SOLR-8621 > URL: https://issues.apache.org/jira/browse/SOLR-8621 > Project: Solr > Issue Type: Task > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Fix For: 5.5, master > > Attachments: SOLR-8621-example_contrib_configs.patch, > SOLR-8621-example_contrib_configs.patch, SOLR-8621.patch, > explicit-merge-auto-set.patch > > > *<mergePolicyFactory> end-user benefits:* > * Lucene's UpgradeIndexMergePolicy can be configured in Solr > * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr > * customisability: arbitrary merge policies including wrapping/nested merge > policies can be created and configured > *(proposed) roadmap:* > * solr 5.5 introduces <mergePolicyFactory> support > * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support > * solr 6.0(\?) removes <mergePolicy> support > +work left-to-do summary:+ > * Solr Reference Guide changes (directly in Confluence?) > * changes to remaining solrconfig.xml > ** solr/core/src/test-files/solr/collection1/conf - in SOLR-8674 > ** solr/server/solr/configsets - master committed, branch_5x/branch_5_5 > cherry-pick to follow > * WrapperMergePolicyFactory.getMergePolicyInstance method - master > committed, branch_5x/branch_5_5 cherry-pick to follow > * RandomForceMergePolicyFactory - master committed, branch_5x/branch_5_5 > cherry-pick to follow > +open question:+ > * Do we want to error if luceneMatchVersion >= 5.5 and deprecated > mergePolicy/mergeFactor/maxMergeDocs are used? See [~hossman]'s comment on > Feb 1st. The code as-is permits mergePolicy irrespective of > luceneMatchVersion, I think. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org