[
https://issues.apache.org/jira/browse/SOLR-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145596#comment-15145596
]
Keith Laban commented on SOLR-8371:
-----------------------------------
I see that this part of the code is being ported from the previous
implementation, but, what are the effects of canceling recovery and then
throttling the next recovery? Would it be more efficient to let to original
recovery finish and have the next pending recovery fired once the original one
is done? It seems counter intuitive to cancel the current progress then wait to
start it again if the throttling strategy says so. With these changes there
should always be one pending recovery as long there has been a recovery request
since the currently running one has started.
My depth of knowledge here is pretty limited so I'm not sure if finishing
current recovery and then picking up the missing pieces would be better than
stopping and starting, just throwing in some thoughts.
> Try and prevent too many recovery requests from stacking up and clean up some
> faulty logic.
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-8371
> URL: https://issues.apache.org/jira/browse/SOLR-8371
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.5, master
>
> Attachments: SOLR-8371-2.patch, SOLR-8371.patch, SOLR-8371.patch,
> SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch, SOLR-8371.patch,
> SOLR-8371.patch, SOLR-8371.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
