[ 
https://issues.apache.org/jira/browse/SOLR-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148344#comment-15148344
 ] 

Tommaso Teofili commented on SOLR-7739:
---------------------------------------

After having had a closer look at the code I think it generally looks good.
One thing I noticed is that the {{Query}} parameter to build {{Classifiers}} 
that use a subset of the index is missing, while it's ok for a first 
implementation I think that may be good to have, also maybe in the future we 
may want to decouple the field that is used as the target classification value 
(e.g. used for "training") from the field where we put the actual 
classification value assigned by the {{Classifier}} to the document.
However I'm generally fine with the current state, but it'd be good if we could 
fix the _ant idea_ and _ant eclipse_ targets to correctly set Lucene 
Classification jar into Solr's classpath otherwise no one will be able to e.g. 
run tests from IDE anymore after this patch has been committed.

> Lucene Classification Integration - UpdateRequestProcessor
> ----------------------------------------------------------
>
>                 Key: SOLR-7739
>                 URL: https://issues.apache.org/jira/browse/SOLR-7739
>             Project: Solr
>          Issue Type: New Feature
>          Components: update
>    Affects Versions: 5.2.1
>            Reporter: Alessandro Benedetti
>            Assignee: Tommaso Teofili
>            Priority: Minor
>              Labels: classification, index-time, update.chain, 
> updateProperties
>         Attachments: SOLR-7739.1.patch, SOLR-7739.patch, SOLR-7739.patch
>
>
> It would be nice to have an UpdateRequestProcessor to interact with the 
> Lucene Classification Module and provide an easy way of auto classifying Solr 
> Documents on indexing.
> Documentation will be provided with the patch
> A first design will be provided soon.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to