[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154388#comment-15154388
]
Shai Erera commented on SOLR-8621:
----------------------------------
I am not sure how to comment on those pages, so I'll comment here:
bq. {{<mergePolicyFactory class="org.apache.lucene.index.TieredMergePolicy">}}
Shouldn't the class be {{TieredMergePolicyFactory}}?
bq. This process can continue indefinitely
Well, not indefinitely :). More like "The process can continue until there are
no more {{mergeFactor}} segments to merge of same size".
bq. and the maxMergeAtOnce setting determines how many segments should be
included in the merge
Perhaps "... should be included in each merge"? Cause if segmentsPerTier is 30
and maxMergeAtOnce is 10, there will be 3 merges.
bq. It also can also result
One extra 'also' here.
bq. {{class="MyCustomMergePolicyFactory"}}
Should we write {{class="full.package.MyCustomMergePolicyFactory"}}? It's not
critical but I want to emphasize that one cannot just give the class name here,
but needs to FQCN.
bq. {{org.apache.solr.index.TieredMergePolicyFactory}}
If {{solr.TieredMergePolicyFactory}} works too, let's write that? That way, if
the factory changes packages, we won't need to update the guide.
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Fix For: 5.5, master
>
> Attachments: SOLR-8621-example_contrib_configs.patch,
> SOLR-8621-example_contrib_configs.patch, SOLR-8621.patch,
> explicit-merge-auto-set.patch
>
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * Lucene's SortingMergePolicy can be configured in Solr (with SOLR-5730)
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5 deprecates (but maintains) <mergePolicy> support
> * SOLR-8668 in solr 6.0(\?) will remove <mergePolicy> support
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
