[ 
https://issues.apache.org/jira/browse/LUCENE-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157752#comment-15157752
 ] 

Uwe Schindler commented on LUCENE-7041:
---------------------------------------

Hi Lewis,
unfortunately, your patch is not enough! Lucene does not use transitive 
dependecies anywhere. So when you update TIKA, you also have to verify the 
dependencies of TIKA and update the other versions listed in ivy-versions.xml 
to the ones that are required by TIKA (e.g. PDFBOX, ROME,...). Not doing this 
will make the tests of the contrib/extraction module to fail.

To test the upgrade, you must run "ant test" inside the contrib/extraction 
module.

Please also make sure to update PDFBOX to one newer than the one required by 
TIKA, because we need the BUG in PDFBOX to be fixed, that makes it not work 
with Java 9 (Lucene and Solr tests must pass with Java 9 previews). The version 
currently shipped with TIKA 1.12 is broken, unfortunately.

The hard part in updating is:
- You have to be sure that you don't upgrade a library required by TIKA that 
Solr needs in another/older version (there are several ones). We generally 
disable those parsers that require incorrect versions.
- If you really need to upgrade some library required for TIKA and we must 
update Solr's shared one, it gets complicated and needs a lot of testing, so it 
should generally be avoided. This is the reason why TIKA gets updated sparingly 
in Solr. The dependency-hell as introduced by TIKA is horrible for us to manage 
- in fact its a desaster!

{noformat}
Trivial update. @uschindler I attempted running ant test locally with the 
following failures
   [junit4] Suite: org.apache.solr.search.TestSolrJ
   [junit4] Completed [579/579 (6!)] on J3 in 0.02s, 1 test
   [junit4]
   [junit4]
   [junit4] Tests with failures [seed: 64AD6FE9325CC7B0]:
   [junit4]   - org.apache.solr.cloud.TestRequestStatusCollectionAPI.test
   [junit4]   - org.apache.solr.cloud.DistribCursorPagingTest.test
   [junit4]   - org.apache.solr.cloud.DeleteLastCustomShardedReplicaTest.test
   [junit4]   - org.apache.solr.cloud.SimpleCollectionCreateDeleteTest.test
   [junit4]   - 
org.apache.solr.cloud.TestMiniSolrCloudCluster.testSegmentTerminateEarly
   [junit4]   - 
org.apache.solr.cloud.TestMiniSolrCloudCluster.testStopAllStartAll
   [junit4]   - 
org.apache.solr.cloud.TestMiniSolrCloudCluster.testCollectionCreateWithoutCoresThenDelete
   [junit4]   - 
org.apache.solr.cloud.TestMiniSolrCloudCluster.testCollectionCreateSearchDelete
   [junit4]   - 
org.apache.solr.handler.admin.CoreAdminHandlerTest.testDeleteInstanceDir
   [junit4]   - org.apache.solr.handler.admin.CoreAdminHandlerTest (suite)
   [junit4]
   [junit4]
   [junit4] JVM J0:     0.60 ..   655.76 =   655.16s
   [junit4] JVM J1:     0.85 ..   656.59 =   655.74s
   [junit4] JVM J2:     0.85 ..   200.28 =   199.44s
   [junit4] JVM J3:     0.60 ..  1037.32 =  1036.72s
   [junit4] Execution time total: 17 minutes 17 seconds
   [junit4] Tests summary: 579 suites (8 ignored), 2331 tests, 2 suite-level 
errors, 8 errors, 1 failure, 1320 ignored (59 assumptions)

BUILD FAILED
/usr/local/lucene-solr/build.xml:59: The following error occurred while 
executing this line:
/usr/local/lucene-solr/solr/build.xml:233: The following error occurred while 
executing this line:
/usr/local/lucene-solr/solr/common-build.xml:524: The following error occurred 
while executing this line:
/usr/local/lucene-solr/lucene/common-build.xml:1457: The following error 
occurred while executing this line:
/usr/local/lucene-solr/lucene/common-build.xml:1014: There were test failures: 
579 suites (8 ignored), 2331 tests, 2 suite-level errors, 8 errors, 1 failure, 
1320 ignored (59 assumptions) [seed: 64AD6FE9325CC7B0]

Total time: 34 minutes 7 seconds
{noformat}

These are unrelated failures in the Solr core module. You should run tests in 
contrib/extraction only as a start. Fixing your whole test setup to make 
everything work can be done afterwards.

I assume you never ran tests in contrib/extraction, because it failed already 
before. I am quite sure that contrib/extraction will fail completely because of 
the non-yet updated dependencies.

> Upgrade to Apache Tika 1.12
> ---------------------------
>
>                 Key: LUCENE-7041
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7041
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Lewis John McGibbney
>            Assignee: Uwe Schindler
>             Fix For: master
>
>         Attachments: LUCENE-7041.patch
>
>
> We recently released Apache Tika 1.12. In order to use the fixes provided 
> within the Tika.translate API I propose to upgrade Tika from 1.7 --> 1.12 in 
> lucene/ivy-versions.properties.
> Patch coming up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to