[ 
https://issues.apache.org/jira/browse/LUCENE-7042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158018#comment-15158018
 ] 

ASF subversion and git services commented on LUCENE-7042:
---------------------------------------------------------

Commit 9ca1a19b81448594bbaf046da5d5e33228e6974f in lucene-solr's branch 
refs/heads/master from [~rcmuir]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ca1a19 ]

LUCENE-7042: more cleanup for Point encodings


> more cleanup for Point encodings
> --------------------------------
>
>                 Key: LUCENE-7042
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7042
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>         Attachments: LUCENE-7042.patch
>
>
> Followup of LUCENE-7039.
> I started consolidating encode/decode functions into XYZField, but its still 
> pretty messy. Specifically, duplicated code because indexer wants packed 
> byte[] and queries want byte[][] and so on.
> We can do a bit more cleanup: by defining everything in terms of 
> encodeDimension() and decodeDimension(). This way, the logic is only in one 
> place. 
> Also the new NumericUtils methods here are confusing I think. Its scary how 
> they take a "dimensional index" when parsing from a byte[]. I think they 
> should just take 'offset' and not try to be fancy, its easier to understand.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to