[ 
https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171027#comment-15171027
 ] 

Uwe Schindler edited comment on LUCENE-7053 at 2/28/16 12:47 PM:
-----------------------------------------------------------------

As we implemented {{compareTo}} we could remove the comparator completely. One 
could use {{Comparator.naturalOrder()}}(see 
[[https://docs.oracle.com/javase/8/docs/api/java/util/Comparator.html#naturalOrder--]])
 instead (naturalOrder is defined to use {{compareTo}}. At places like 
Collections.sort() we could remove the comparator argument completely.

Any comments on this?


was (Author: thetaphi):
As we implemented {{compareTo}} we could remove the comparator completely. One 
could use {{Collections.naturalOrder()}} instead (naturalOrder is defined to 
use {{compareTo}}. At places like Collections.sort() we could remove the 
comparator argument completely.

Any comments on this?

> Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator()
> -----------------------------------------------------------
>
>                 Key: LUCENE-7053
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7053
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7053.patch, LUCENE-7053.patch, LUCENE-7053.patch
>
>
> Followup from LUCENE-7052: This removes the legacy, deprecated 
> getUTF8SortedAsUTF16Comparator() in the BytesRef class. The only left over 
> user was TSTLookup. Moves the code there as private impl detail.
> This also converts the comparators to lambdas for better readability.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to