[
https://issues.apache.org/jira/browse/SOLR-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171257#comment-15171257
]
ASF GitHub Bot commented on SOLR-7516:
--------------------------------------
GitHub user bvanalderweireldt opened a pull request:
https://github.com/apache/lucene-solr/pull/17
SOLR-7516 add asserts and Improve Javadoc comments (patch from gerlow…
add asserts and Improve Javadoc comments (patch from gerlowskija)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bvanalderweireldt/lucene-solr SOLR-7516
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit 59ea719566a6df47309a1696af3629a545f17d24
Author: bvanalderweireldt <[email protected]>
Date: 2016-02-29T00:09:57Z
SOLR-7516 add asserts and Improve Javadoc comments (patch from gerlowskija)
----
> Improve javadocs for JavaBinCodec, ObjectResolver and enforce the
> single-usage policy
> -------------------------------------------------------------------------------------
>
> Key: SOLR-7516
> URL: https://issues.apache.org/jira/browse/SOLR-7516
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Labels: difficulty-easy, newdev
> Fix For: 5.2, master
>
> Attachments: SOLR-7516.patch
>
>
> The Javadocs of this class can use some improvements. It doesn't adequately
> describe the purpose of the ObjectResolver. Also, since it says that this
> object should be used only once for marshalling or unmarshalling operation,
> we should enforce it in code via asserts and/or exceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
