[ 
https://issues.apache.org/jira/browse/SOLR-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177998#comment-15177998
 ] 

ASF subversion and git services commented on SOLR-8778:
-------------------------------------------------------

Commit a079ff2528a384468289a8fb80787b418c887496 in lucene-solr's branch 
refs/heads/master from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a079ff2 ]

SOLR-8778: Deprecate CSVStrategy's setters, and make its pre-configured 
strategies immutable


> Deprecate CSVStrategy's setters, and make its pre-configured strategies 
> immutable
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-8778
>                 URL: https://issues.apache.org/jira/browse/SOLR-8778
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Steve Rowe
>         Attachments: SOLR-8778.patch
>
>
> Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug: 
> it's possible to redefine the public static 
> {{CSVStrategy.\{DEFAULT,EXCEL,TDF}_STRATEGY}} strategies, simply by calling 
> their setters.
> Right now that's happening in {{CSVParserTest.testUnicodeEscape()}}, where 
> the default unicode escape interpretation is changed from false to true.  And 
> then if that test happens to run before 
> {{CSVStrategyTest.testSetCSVStrategy()}}, which tests that the unicode escape 
> interpretation on the default strategy is set to false, then the latter will 
> fail.
> Example failures: 
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and 
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to