[ 
https://issues.apache.org/jira/browse/LUCENE-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179705#comment-15179705
 ] 

Michael McCandless commented on LUCENE-7056:
--------------------------------------------

bq. Since its dependency free I still think it makes most sense to refactor it 
to the spatial module under a geometry package and just have the spatial and 
spatial-extras modules. Having a third just for a geometry model doesn't make 
sense to me.

+1

bq. I'm also not a fan of the name *3d. It causes confusion that this package 
handles altitude.

+1

I feel the "3d-ness" is an implementation detail about how this package does 
very accurate spatial math, vs the 2d math in projected space which seems to be 
hard to get right (troubles we've had with the 2D points-based distance query).

bq. Personally i would think it should be named org.apache.lucene.spatial3d and 
org.apache.lucene.spatial3d.geom.

+1

So the user would use {{o.a.l.spatial3d.Geo3DPoint}} to do indexing and create 
queries, and then the {{geom}} sub-package has all the under-the-hood math.

> Spatial3d/Geo3d should have zero runtime dependencies
> -----------------------------------------------------
>
>                 Key: LUCENE-7056
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7056
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial3d
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 6.0
>
>
> This is a proposal for the "spatial3d" module to be purely about the 
> shape/geometry implementations it has.  In Lucene 5 that's actually all it 
> has.  In Lucene 6 at the moment its ~76 files have 2 classes that I think 
> should go elsewhere: Geo3DPoint and PointInGeo3DShapeQuery.  Specifically 
> lucene-spatial-extras (which doesn't quite exist yet so lucene-spatial) would 
> be a suitable place due to the dependency.   _Eventually_ I see this module 
> migrating elsewhere be it on its own or a part of something else more 
> spatial-ish.  Even if that never comes to pass, non-Lucene users who want to 
> use this module for it's geometry annoyingly have to exclude the Lucene 
> dependencies that are there because this module also contains these two 
> classes.
> In a comment I'll suggest some specifics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to