Thanks Shalin.

Mike McCandless

http://blog.mikemccandless.com


On Fri, Mar 4, 2016 at 9:45 AM, Shalin Shekhar Mangar
<[email protected]> wrote:
> Okay thanks for the background. I have removed that comment from
> master, branch_6x and branch_6_0.
>
> On Fri, Mar 4, 2016 at 1:08 AM, Michael McCandless
> <[email protected]> wrote:
>> Thanks for fixing this Shalin, the test passes for me now!
>>
>>> assert is40Index; // NOTE: currently we can only do this on trunk!
>>
>> LOL how confusing.  I suspect the comment is (very) stale, and what
>> the comment really means is "NOTE: we can only do this for all indices
>>>= 4.0", i.e. when doc values were added.  Maybe simply remove the
>> comment?  The comments above (// true if this is a 4.0+ index) is
>> correct.
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>
>
>
> --
> Regards,
> Shalin Shekhar Mangar.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to