[
https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-6952:
---------------------------------
Attachment: LUCENE_6952.patch
I expanded the scope to include any class starting with Filter that is a
delegate that wasn't already abstract:
Lucene-core:
* FilterCodecReader
* FilterLeafReader
* FilterCollector
* FilterDirectory
Lucene-test-framework
* FilterFileChannel
* FilterFileStore
* _not_ FilterFileSystem
* FilterFileSystemProvider
* FilterOutputStream2
* _not_ FilterPath
When I had tentatively made FilterFileSystem and FilterPath abstract, I noticed
a bunch of direct usages that seemed to use it as a pair of a delegate with a
FileSystem impl so it wasn't a pure delegate. But that's debatable; it's fine
either way I guess.
> FilterLeafReader and friends should be abstract
> -----------------------------------------------
>
> Key: LUCENE-6952
> URL: https://issues.apache.org/jira/browse/LUCENE-6952
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Minor
> Fix For: master
>
> Attachments: LUCENE_6952.patch
>
>
> I think it's confusing that FilterLeafReader (and it's Filter\* inner
> classes) are not abstract. By making them abstract, we clarify to users how
> to use them by virtue of them being abstract. It seems only a couple tests
> directly instantiate them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
