[
https://issues.apache.org/jira/browse/LUCENE-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-7056:
---------------------------------
Attachment: LUCENE_7056__split_spatial3d_package.patch
I've updated the patch since there were conflicts due to LUCENE-7072. I also
noticed GeoPointTest in lucene-spatial-extras that should be moved to the other
tests in spatial3d simply by removing a trivial reference to Spatial4j's
DistanceUtils so I did that.
FYI contrary to my claim in a comment or two ago, the Geo3d brand/name whatever
lives on as there's Geo3dPoint, Geo3dShape and some misc utilities starting
with that prefix.
I'll commit this tonight as I think we have agreement here, but if I get a +1 I
may do it sooner.
> Spatial3d/Geo3d should have zero runtime dependencies
> -----------------------------------------------------
>
> Key: LUCENE-7056
> URL: https://issues.apache.org/jira/browse/LUCENE-7056
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 6.0
>
> Attachments: LUCENE_7056__split_spatial3d_package.patch,
> LUCENE_7056__split_spatial3d_package.patch
>
>
> This is a proposal for the "spatial3d" module to be purely about the
> shape/geometry implementations it has. In Lucene 5 that's actually all it
> has. In Lucene 6 at the moment its ~76 files have 2 classes that I think
> should go elsewhere: Geo3DPoint and PointInGeo3DShapeQuery. Specifically
> lucene-spatial-extras (which doesn't quite exist yet so lucene-spatial) would
> be a suitable place due to the dependency. _Eventually_ I see this module
> migrating elsewhere be it on its own or a part of something else more
> spatial-ish. Even if that never comes to pass, non-Lucene users who want to
> use this module for it's geometry annoyingly have to exclude the Lucene
> dependencies that are there because this module also contains these two
> classes.
> In a comment I'll suggest some specifics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
