[ 
https://issues.apache.org/jira/browse/LUCENE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-7073:
--------------------------------
    Attachment: LUCENE-7073.patch

Here is an improvement that makes the test a little less lenient, it adds 
missing bounds checks (and fixes error messages) for FieldType.setDimensions().

> FieldType problems with Points
> ------------------------------
>
>                 Key: LUCENE-7073
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7073
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7073.patch, LUCENE-7073.patch
>
>
> The "copy constructor" is buggy and ignores the incoming points properties, 
> because of a bug:
> {code}
>   public FieldType(FieldType ref) {
>     ...
>     // these two assignments have no effect. 
>     this.dimensionCount = dimensionCount;
>     this.dimensionNumBytes = dimensionNumBytes;
> {code}
> Another issue is that tokenized() returns true for all these point fields, 
> which is bogus, and it confuses things like transitioning to points in some 
> benchmark code (trying to clean up places still using LegacyNumeric* !!!). 
> This code checks if (tokenized()) { try to use tokenstream }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to