[ 
https://issues.apache.org/jira/browse/LUCENE-7073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183348#comment-15183348
 ] 

Uwe Schindler edited comment on LUCENE-7073 at 3/7/16 6:27 PM:
---------------------------------------------------------------

To prevent things like the typo in method names, i would look up the method 
before the loop from the class. And inside the loop check for method equality. 
By that you make sure that the method really exists.

In addition, assert that the method was called at least once!


was (Author: thetaphi):
To prevent things like the typo in method names, i would look up the method 
before the loop from the class. And inside the loop check for method equality. 
By that you make sure that the method really exists.

> FieldType problems with Points
> ------------------------------
>
>                 Key: LUCENE-7073
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7073
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7073.patch, LUCENE-7073.patch
>
>
> The "copy constructor" is buggy and ignores the incoming points properties, 
> because of a bug:
> {code}
>   public FieldType(FieldType ref) {
>     ...
>     // these two assignments have no effect. 
>     this.dimensionCount = dimensionCount;
>     this.dimensionNumBytes = dimensionNumBytes;
> {code}
> Another issue is that tokenized() returns true for all these point fields, 
> which is bogus, and it confuses things like transitioning to points in some 
> benchmark code (trying to clean up places still using LegacyNumeric* !!!). 
> This code checks if (tokenized()) { try to use tokenstream }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to