[
https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-6952:
---------------------------------
Attachment: LUCENE_6952.patch
Updated to fix bug introduced in my patch related to the presence of trivial
anonymous inner subclasses that didn't need to be there any more. They were
there because the very first attempt made some classes Abstract and I had since
changed my mind. A test discovered this.
> All Filter* delegating classes should be abstract
> -------------------------------------------------
>
> Key: LUCENE-6952
> URL: https://issues.apache.org/jira/browse/LUCENE-6952
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master
>
> Attachments: LUCENE_6952.patch, LUCENE_6952.patch
>
>
> I think it's confusing that FilterLeafReader (and it's Filter\* inner
> classes) are not abstract. By making them abstract, we clarify to users how
> to use them by virtue of them being abstract. It seems only a couple tests
> directly instantiate them. This applies to other Filter* classes as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
