[
https://issues.apache.org/jira/browse/LUCENE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185326#comment-15185326
]
ASF subversion and git services commented on LUCENE-6952:
---------------------------------------------------------
Commit 9393a3190ce6af48ae0aac40d5d4b17c3b5d5423 in lucene-solr's branch
refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9393a31 ]
LUCENE-6952: Make most Filter* classes abstract.
> All Filter* delegating classes should be abstract
> -------------------------------------------------
>
> Key: LUCENE-6952
> URL: https://issues.apache.org/jira/browse/LUCENE-6952
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: master
>
> Attachments: LUCENE_6952.patch, LUCENE_6952.patch
>
>
> I think it's confusing that FilterLeafReader (and it's Filter\* inner
> classes) are not abstract. By making them abstract, we clarify to users how
> to use them by virtue of them being abstract. It seems only a couple tests
> directly instantiate them. This applies to other Filter* classes as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
