[
https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186697#comment-15186697
]
Jan Høydahl commented on SOLR-6246:
-----------------------------------
I was thinking more that in preReload() the old Suggester simply shuts down,
freeing up any locks and making suggest unavailable. Then the reload will not
fail due to locks, but there is a (potentially long) time span where suggest is
unavailable. I feel this is better than failing reloads, which in most
environments do not take place very frequently after all.
> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
> Key: SOLR-6246
> URL: https://issues.apache.org/jira/browse/SOLR-6246
> Project: Solr
> Issue Type: Sub-task
> Components: SearchComponents - other
> Affects Versions: 4.8, 4.8.1, 4.9
> Reporter: Varun Thacker
> Fix For: 5.2, master
>
> Attachments: SOLR-6246-test.patch, SOLR-6246-test.patch,
> SOLR-6246.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to
> AnalyzingInfixSuggester. One of the changes that went in was a writer is
> persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester
> is created. When trying to create a new writer on the same Directory a lock
> cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should
> pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a
> reloadHook where we close the writer?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
