[
https://issues.apache.org/jira/browse/SOLR-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188416#comment-15188416
]
Jason Gerlowski edited comment on SOLR-8765 at 3/10/16 1:15 AM:
----------------------------------------------------------------
IMO, Id rather have {{SolrIdentifierValidator}} return boolean than
SolrException. SolrException is intended to be used on the server side, as it
can be converted into a status code. That aspect of the exception doesn't make
a ton of sense being used on the client/Solr J side.
(Disclaimer, when I first wrote SolrIdentifierValidator, I had it throwing
SolrException. I was then converted after talking to Anshum about the downsides
of using it client-side)
was (Author: gerlowskija):
IMO, Id rather have {{SolrIdentifierValidator}} throw IAE than SolrException.
SolrException is intended to be used on the server side, as it can be converted
into a status code. That aspect of the exception doesn't make a ton of sense
being used on the client/Solr J side.
(Disclaimer, when I first wrote SolrIdentifierValidator, I had it throwing
SolrException. I was then converted after talking to Anshum about the downsides
of using it client-side)
> Enforce required parameters in SolrJ Collection APIs
> ----------------------------------------------------
>
> Key: SOLR-8765
> URL: https://issues.apache.org/jira/browse/SOLR-8765
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Fix For: 6.1
>
> Attachments: SOLR-8765.patch, SOLR-8765.patch
>
>
> Several Collection API commands have required parameters. We should make
> these constructor parameters, to enforce setting these in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
