[ 
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189585#comment-15189585
 ] 

Keith Laban edited comment on SOLR-8599 at 3/10/16 5:27 PM:
------------------------------------------------------------

uploaded a new patch against master addressing Uwes concerns. I see that this 
was already merged in master, but that seems to be the only branch its 
currently on so hopefully its ok to put this out there.

Instead of scheduling a thread to change the address I was able to mock the 
DefaultConnectionStrategy to throw an exception in the reconnect call the first 
time its called to verify that it is being retried. With this change I also 
changed the server address to be final again and removed the public setter 
method seeing how they were no longer needed

Note: The new patch doesn't have the changes which introduced the retry logic 
in {{ConnectionManager}} since that part is already merged in on the master 
branch. I can put in a separate patch containing both for backport to branch_6x 
and branch_5x


was (Author: k317h):
uploaded a new patch against master addressing Uwes concerns. I see that this 
was already merged in master, but that seems to be the only branch its 
currently on so hopefully its ok to put this out there.

Instead of scheduling a thread to change the address I was able to mock the 
DefaultConnectionStrategy to throw an exception in the reconnect call the first 
time its called to verify that it is being retried. With this change I also 
changed the server address to be final again and removed the public setter 
method seeing how they were no longer needed

> Errors in construction of SolrZooKeeper cause Solr to go into an inconsistent 
> state
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-8599
>                 URL: https://issues.apache.org/jira/browse/SOLR-8599
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Keith Laban
>            Assignee: Dennis Gove
>         Attachments: SOLR-8599.patch, SOLR-8599.patch, SOLR-8599.patch, 
> SOLR-8599.patch
>
>
> We originally saw this happen due to a DNS exception (see stack trace below). 
> Although any exception thrown in the constructor of SolrZooKeeper or the 
> parent class, ZooKeeper, will cause DefaultConnectionStrategy to fail to 
> update the zookeeper client. Once it gets into this state, it will not try to 
> connect again until the process is restarted. The node itself will also 
> respond successfully to query requests, but not to update requests.
> Two things should be address here:
> 1) Fix the error handling and issue some number of retries
> 2) If we are stuck in a state like this stop responding to all requests 
> {code}
> 2016-01-23 13:49:20.222 ERROR ConnectionManager [main-EventThread] - 
> :java.net.UnknownHostException: HOSTNAME: unknown error
> at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
> at java.net.InetAddress$2.lookupAllHostAddr(InetAddress.java:928)
> at java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1323)
> at java.net.InetAddress.getAllByName0(InetAddress.java:1276)
> at java.net.InetAddress.getAllByName(InetAddress.java:1192)
> at java.net.InetAddress.getAllByName(InetAddress.java:1126)
> at 
> org.apache.zookeeper.client.StaticHostProvider.<init>(StaticHostProvider.java:61)
> at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:445)
> at org.apache.zookeeper.ZooKeeper.<init>(ZooKeeper.java:380)
> at org.apache.solr.common.cloud.SolrZooKeeper.<init>(SolrZooKeeper.java:41)
> at 
> org.apache.solr.common.cloud.DefaultConnectionStrategy.reconnect(DefaultConnectionStrategy.java:53)
> at 
> org.apache.solr.common.cloud.ConnectionManager.process(ConnectionManager.java:132)
> at 
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
> at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
> 2016-01-23 13:49:20.222 INFO ConnectionManager [main-EventThread] - 
> Connected:false
> 2016-01-23 13:49:20.222 INFO ClientCnxn [main-EventThread] - EventThread shut 
> down
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to