[
https://issues.apache.org/jira/browse/SOLR-8790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15190544#comment-15190544
]
Varun Thacker commented on SOLR-8790:
-------------------------------------
Hi Anshum,
Thanks for fixing the code! Patch looks good
Just looking at the OverseerCollectionMessageHandler there are different things
being set as nodeName in different places:
For example,
processRebalanceLeaders does this - {{sreq.nodeName =
message.getStr(ZkStateReader.CORE_NAME_PROP);}}
addReplica does this - {{String node = message.getStr(CoreAdminParams.NODE);}}
Everyone else sets nodeName as {{ZkStateReader.NODE_NAME_PROP}}
I think we should also add some javadocs to {{sendShardRequest}} and
{{ShardRequest.java}}
> Add node name back to the core level responses in OverseerMessageHandler
> ------------------------------------------------------------------------
>
> Key: SOLR-8790
> URL: https://issues.apache.org/jira/browse/SOLR-8790
> Project: Solr
> Issue Type: Bug
> Reporter: Anshum Gupta
> Attachments: SOLR-8790.patch
>
>
> Continuing from SOLR-8789, now that this test runs, time to fix it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
