[
https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199799#comment-15199799
]
Yonik Seeley commented on SOLR-8866:
------------------------------------
+1, looks fine.
> UpdateLog should throw an exception when serializing unknown types
> ------------------------------------------------------------------
>
> Key: SOLR-8866
> URL: https://issues.apache.org/jira/browse/SOLR-8866
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch
>
>
> When JavaBinCodec encounters a class it doesn't have explicit knowledge of
> how to serialize, nor does it implement the {{ObjectResolver}} interface, it
> currently serializes the object as the classname, colon, then toString() of
> the object.
> This may appear innocent but _not_ throwing an exception hides bugs. One
> example is that the UpdateLog, which uses JavaBinCodec, to save a document.
> The result is that this bad value winds up there, gets deserialized as a
> String in PeerSync (which uses /get) and then this value pretends to be a
> suitable value to the final document in the leader. But of course it isn't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
