2011/3/21 Earwin Burrfoot <[email protected]>: > Technically, there's a big difference between "I checked, and there > was no index", and "I was unable to check the disk because file system > went BANG!". > So the proper behaviour is to return false & IOE (on proper occasion)?
+1 to throw the exception when proper to do so Otherwise please keep the throws declaration so that you won't break public APIs if this changes implementation. > > On Mon, Mar 21, 2011 at 13:53, Michael McCandless > <[email protected]> wrote: >> On Mon, Mar 21, 2011 at 12:52 AM, Shai Erera <[email protected]> wrote: >>> Can we remove the declaration? The method never throws IOE, but instead >>> catches it and returns false. I think it's reasonable that such a method >>> will not throw exceptions. >> >> +1 >> >> -- >> Mike >> >> http://blog.mikemccandless.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > > -- > Kirill Zakharenko/Кирилл Захаренко > E-Mail/Jabber: [email protected] > Phone: +7 (495) 683-567-4 > ICQ: 104465785 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
