[ 
https://issues.apache.org/jira/browse/LUCENE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206617#comment-15206617
 ] 

ASF subversion and git services commented on LUCENE-7128:
---------------------------------------------------------

Commit 275a259b1fa0d94aec95f554c2c7451b8678bd8e in lucene-solr's branch 
refs/heads/master from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=275a259 ]

LUCENE-7128: clean up new geo APIs to consistently take lat before lon, make 
methods private when possible, use lat/lon instead of y/x naming, remove unused 
code


> Fix spatial and sandbox geo APIs to consistently take lat before lon
> --------------------------------------------------------------------
>
>                 Key: LUCENE-7128
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7128
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master, 6.0
>
>         Attachments: LUCENE-7128.patch
>
>
> Right now sometimes it's lat, lon and other times it's lon, lat which
> is just asking for horrors of biblical proportions.
> I went through and carefully fixed them to take lat, lon in all places
> I could find, and renamed y -> lat and x -> lon.  I also removed
> unused code, or code only called from tests: I think Lucene shouldn't
> just export spatial APIs unless we also ourselves need them for
> indexing and searching.  Finally, I tried to shrink wrap the APIs,
> making previously public apis private if nobody external invoked them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to