[
https://issues.apache.org/jira/browse/LUCENE-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208186#comment-15208186
]
Michael McCandless commented on LUCENE-7127:
--------------------------------------------
bq. Yeah but its not working: this multithreaded test doesnt reproduce
correctly.
Rob suspected and I verified that it's the query cache that made the seeds not
reproduce the threaded tests here.
I disabled the query cache, then beasted an unrelated patch to a failing seed
on the threads test and confirmed that it reliably reproduces now.
It's because, depending on thread scheduling, and also because we seed all
threads identically, different threads will hit a cache hit vs miss, leading to
different random paths for each.
> remove epsilon-based testing from lucene/spatial
> ------------------------------------------------
>
> Key: LUCENE-7127
> URL: https://issues.apache.org/jira/browse/LUCENE-7127
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Robert Muir
> Fix For: master, 6.1
>
> Attachments: LUCENE-7127.patch, LUCENE-7127.patch, LUCENE-7127.patch,
> LUCENE-7127.patch
>
>
> Currently, the random tests here allow a TOLERANCE and will fail if the error
> exceeds. But this is not fun to debug! It also keeps the door wide open for
> bugs to creep in.
> Alternatively, we can rework the tests like we did for sandbox/ points. This
> means the test is aware of the index-time quantization and so it can demand
> exact answers.
> Its more difficult at first, because even floating point error can cause a
> failure. It requires us to maybe work through corner cases/rework
> optimizations. If any epsilons must be added, they can be added to the
> optimizations themselves (e.g. bounding box) instead of the user's result.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
