[ 
https://issues.apache.org/jira/browse/SOLR-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210469#comment-15210469
 ] 

David Smiley commented on SOLR-6359:
------------------------------------

Maybe I misunderstand the impacts of these configuration options, but why even 
have a maxNumLogsToKeep?  i.e. why isn't it effectively unlimited?  I don't 
care how many internal log files the updateLog would like to do its 
implementation-detail business, so long as I can specify that it has docs added 
within the last X minutes, and maybe a minimum number of docs.  Sounds 
reasonable?  Because X minutes allows me to specify a server restart worth of 
time.  That 'X' minutes is basically the hard auto commit interval, since 
that's what truncates the current log to a new file.  [~andyetitmoves] in your 
"heavy indexing setup" couldn't you have just set the auto commit window large 
enough to your liking?  

The current "numRecordsToKeep" (defaulting to 100) doesn't say if it's a min or 
max; it seems to be implemented as a soft maximum -- the oldest log files will 
be removed to stay under, but we'll always have at least one log file, however 
big or small it may be.  In my scenario where I basically don't care how many 
records it actually is (I care about time), I think I can basically ignore this 
(leave at 100).

> Allow customization of the number of records and logs kept by UpdateLog
> -----------------------------------------------------------------------
>
>                 Key: SOLR-6359
>                 URL: https://issues.apache.org/jira/browse/SOLR-6359
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ramkumar Aiyengar
>            Assignee: Ramkumar Aiyengar
>            Priority: Minor
>             Fix For: 5.1, master
>
>         Attachments: SOLR-6359.patch
>
>
> Currently {{UpdateLog}} hardcodes the number of logs and records it keeps, 
> and the hardcoded numbers (100 records, 10 logs) can be quite low (esp. the 
> records) in an heavily indexing setup, leading to full recovery even if Solr 
> was just stopped and restarted.
> These values should be customizable (even if only present as expert options).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to