GitHub user randomstatistic opened a pull request:
https://github.com/apache/lucene-solr/pull/25
SOLR-8785: Use Metrics library for core metrics
There were three main areas that used the copied classes in
org.apache.solr.util.stats:
- AnalyticsStatisticsCollector
- Overseer.Stats
- RequestHandlerBase
This patch adds depreciation tags to all the copied classes, and also
replaces all usage of those classes with classes from the Metrics library.
I added one new class (org.apache.solr.util.stats.Metrics) to provide some
common access patterns for metrics gathering.
This patch only adds Registry-based tracking to RequestHandlerBase,
although all three areas are a fit for it. The effect is that all one needs to
do is add a Reporter to the SharedMetricRegistry named
âsolr.registry.requesthandlerâ and all named request handler stats will be
exported automatically.
Compatibility notes:
- The âtotalTimeâ stat has been deleted from all three areas. This
never seemed very useful, and Metrics didnât support it in the Timer class,
so it would have required some extra code to keep.
- RequestHandler stats are now persistent, and will no longer reset on
reload.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randomstatistic/lucene-solr metrics_lib
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 77ba4704399ecd5121a6941a3a75c1294172ed21
Author: Jeff Wartes <[email protected]>
Date: 2016-03-16T18:27:35Z
SOLR-8785 - Upgrade Metrics lib
commit 9ad3a8179ac446f5820e051802a37bf8b2ba911b
Author: Jeff Wartes <[email protected]>
Date: 2016-03-18T02:46:49Z
SOLR-8785 - Use the Metrics lib instead of the old classes from the
org.apache.solr.util.stats package space.
commit 6ee11c807aa7432ec02f9ad63aefc7487a02566a
Author: Jeff Wartes <[email protected]>
Date: 2016-03-18T02:55:33Z
SOLR-8785 - Use persistent, reportable timers for named request handlers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
