[ 
https://issues.apache.org/jira/browse/SOLR-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218275#comment-15218275
 ] 

ASF subversion and git services commented on SOLR-8864:
-------------------------------------------------------

Commit 28a51cef56dfc43a935590e57c7cbdc8f84a30ef in lucene-solr's branch 
refs/heads/branch_6x from markrmiller
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=28a51ce ]

SOLR-8864: TestTestInjection needs to cleanup after itself.


> TestTestInjection needs to cleanup after itself -- causes 
> TestCloudDeleteByQuery fail (may be symptom of larger problem?)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8864
>                 URL: https://issues.apache.org/jira/browse/SOLR-8864
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>         Attachments: jenkins.log
>
>
> https://builds.apache.org/job/Lucene-Solr-Tests-6.x/65/ recently reported a 
> failure from TestCloudDeleteByQuery's init methods that made no sense to me 
> -- looking at the logs showed an error from "TestInjection.parseValue" even 
> though this test doesn't do anything to setup TestInjection...
> {noformat}
>    [junit4]   2> 527801 ERROR (qtp1490160324-5239) [n:127.0.0.1:48763_solr 
> c:test_col s:shard1 r:core_node4 x:test_col_shard1_replica2] 
> o.a.s.h.RequestHandlerBase java.lang.RuntimeException: No match, probably bad 
> syntax: TRUE:0:
>    [junit4]   2>      at 
> org.apache.solr.util.TestInjection.parseValue(TestInjection.java:236)
>    [junit4]   2>      at 
> org.apache.solr.util.TestInjection.injectFailReplicaRequests(TestInjection.java:159)
>    [junit4]   2>      at 
> org.apache.solr.update.processor.DistributedUpdateProcessor.setupRequest(DistributedUpdateProcessor.java:356)
> {noformat}
> ...the immediate problem seems to be that TestTestInjection doesn't do 
> anything to cleanup after itself (it never calls {{TestInjection.reset()}}, 
> and doesn't subclass SolrTestCaseJ4) but i'm surprised this hasn't caused a 
> lot more weird failures since this test was added back in december -- i 
> wonder if this this "bad syntax" RuntimeException, when injected into the 
> distributed updates, isn't causing a problem in most cases because of leader 
> initiated recovery, but maybe something specific about the codepaths used in 
> TestCloudDeleteByQuery (which is only a few weeks old) don't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to