[
https://issues.apache.org/jira/browse/LUCENE-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219913#comment-15219913
]
Robert Muir commented on LUCENE-7154:
-------------------------------------
And just pasting that code makes me think its buggy :)
Geo termsenum has:
{code}
@Override
protected boolean cellIntersectsShape(final double minLat, final double
maxLat, final double minLon, final double maxLon) {
return cellContains(minLat, maxLat, minLon, maxLon) || cellWithin(minLat,
maxLat, minLon, maxLon)
|| cellCrosses(minLat, maxLat, minLon, maxLon);
}
{code}
Just shows patch needs some more tests...
> Add support for polygon holes to Geo3D
> --------------------------------------
>
> Key: LUCENE-7154
> URL: https://issues.apache.org/jira/browse/LUCENE-7154
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Karl Wright
> Attachments: LUCENE-7154.diff
>
>
> Real-world polygons (e.g. from ESRI) have holes in them. We need polygon
> support in geo3D that works in the same way.
> The proposal would be to change the GeoConvexPolygon constructor to include a
> number of GeoPolygon inputs, each of which would specify a hole. Then, the
> GeoPolygonFactory.makeGeoPolygon() method would also need to accept a similar
> list of GeoPolygon hole descriptions.
> This change is likely to be fairly complex because of the already tricky
> algorithm used to create convex polygons from non-convex ones, implemented in
> GeoPolygonFactory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
