[ 
https://issues.apache.org/jira/browse/LUCENE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221444#comment-15221444
 ] 

Jan Høydahl commented on LUCENE-7155:
-------------------------------------

[~rjernst] you wrote the initial {{matching_branch}} logic, what ist he 
{{c.branch_type == 'major'}} good for? I'm proposing to change it to {{... or 
c.version.is_major_release() and c.branch_type == BranchType.master}} in 
{{LUCENE-7155-improve.patch}}

> Script addVersion.py does not detect the new naming convention for bugfix 
> branches
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-7155
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7155
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: -tools
>    Affects Versions: 5.5, master, 6.0, 6.x
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: 5.5, master
>
>         Attachments: LUCENE-7155-improve.patch, LUCENE-7155.patch
>
>
> Spinoff from LUCENE-6938. Earlier we named release branches 
> {{lucene_solr_X_Y}} while now we name them {{branch_X_Y}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to