[
https://issues.apache.org/jira/browse/LUCENE-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010778#comment-13010778
]
Michael McCandless commented on LUCENE-2985:
--------------------------------------------
Patch looks great!
I wonder if we should pass the segmentCodecsBuilder to FieldInfos? This way,
FieldInfos.add/update could set the codecID, instead of caller doing it after
the fact (in DocFieldProcessorPerThread)?
> Build SegmentCodecs incrementally for consistent codecIDs during indexing
> -------------------------------------------------------------------------
>
> Key: LUCENE-2985
> URL: https://issues.apache.org/jira/browse/LUCENE-2985
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Codecs, Index
> Affects Versions: CSF branch, 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: CSF branch, 4.0
>
> Attachments: LUCENE-2985.patch
>
>
> currently we build the SegementCodecs during flush which is fine as long as
> no codec needs to know which fields it should handle. This will change with
> DocValues or when we expose StoredFields / TermVectors via Codec (see
> LUCENE-2621 or LUCENE-2935). The other downside it that we don't have a
> consistent view of which codec belongs to which field during indexing and all
> FieldInfo instances are unassigned (set to -1). Instead we should build the
> SegmentCodecs incrementally as fields come in so no matter when a codec needs
> to be selected to process a document / field we have the right codec ID
> assigned.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
