[
https://issues.apache.org/jira/browse/LUCENE-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232019#comment-15232019
]
Karl Wright commented on LUCENE-7194:
-------------------------------------
Another way to look at this is that our tests really should not care. In this
view, we should be consistent in our usage of conversion function (e.g. ALWAYS
use StrictMath or Math for this purpose), and fix the one test that is failing:
the test of "toString", which probably doesn't need to be checking all the
numeric values anyway.
> Ban Math.toRadians/toDegrees and remove all usages of it
> --------------------------------------------------------
>
> Key: LUCENE-7194
> URL: https://issues.apache.org/jira/browse/LUCENE-7194
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
>
> The result of these methods is unreliable and changes across jvm versions: we
> cannot use these methods.
> The following program prints 0.7722082215479366 on previous versions of java
> but 0.7722082215479367 on java 9 because Math.toRadians is no longer doing
> the same thing:
> {code}
> public class test {
> public static void main(String args[]) throws Exception {
> System.out.println(Math.toRadians(44.244272));
> }
> }
> {code}
> This is because of https://bugs.openjdk.java.net/browse/JDK-4477961.
> I am not really sure its a bug, because the method says that the conversion
> is "generally inexact".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]