[
https://issues.apache.org/jira/browse/LUCENE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-2986.
---------------------------------
Resolution: Fixed
Committed revision 1085374.
I cleaned up all the tests as Doron suggested, except for the solr
MockConfigurableSimilarity as I discussed (since solr scoring is not yet
per-field, but i have a patch for this that fixes the naming issues there too).
> divorce defaultsimilarityprovider from defaultsimilarity
> --------------------------------------------------------
>
> Key: LUCENE-2986
> URL: https://issues.apache.org/jira/browse/LUCENE-2986
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2986.patch
>
>
> In LUCENE-2236 as a start, we made DefaultSimilarity which implements the
> factory interface (SimilarityProvider), and also extends Similarity.
> Its factory interface just returns itself always by default.
> Doron mentioned it would be cleaner to split the two, and I thought it would
> be good to revisit it later.
> Today as I was looking at SOLR-2338, it became pretty clear that we should do
> this, it makes things a lot cleaner. I think currently its confusing to users
> to see the two apis mixed if they are trying to subclass.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
