[
https://issues.apache.org/jira/browse/LUCENE-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237580#comment-15237580
]
David Smiley commented on LUCENE-7202:
--------------------------------------
Thanks for raising this issue and for "@"-ing us, Karl. I'm sure [~nknize]
might have some input as well.
All/most our spatial implementations can index data provided as a latitude &
longitude point, so I think it's confusing for any one of them to monopolize
the name "LatLonPoint" for itself. It suggests to a user, who doesn't know
about this stuff, that they should go right for the LatLonPoint one and not the
other ones. So either all should have "LatLonPoint" in the name of none of
them should, IMO. We need _some_ aspect of the implementation in the name of
the class to hint at the implementation approach.
bq. GeoPoint: 1 dimension with morton z encoding -> GeoMortonZLatLonPoint
+1 Great name.
Question: should it say "Term" in some way to reflect that it uses the term
dictionary, not "PointValues" like some others do? GeoMortonZTermLatLonPoint.
That's a mouth full, and so colloquially I'm sure we might abbreviate it but it
doesn't have to be a big deal that the class name is long.
Another possible name to throw in there, less long: Geo1DTermLatLonPoint.
Arguably the fact that it's based on Lucene "terms" is more important to put in
the name than the bit interleaving/encoding choice.
bq. LatLonPoint: 2 dimensions -> GeoLatLonPoint
Mmmm; but there's no implementation hint. How about Geo2DLatLonPoint?
bq. Geo3dPoint: 3 dimensions -> GeoXYZPoint
But people want see that their lat-lon data can go in there just as well as it
can the other spatial impls. I like GeoEllipsoidLatLonPoint and
Geo3DLatLonPoint and GeoXYZLatLonPoint options. Slightly prefer the 3D one
only because it's been in the name thus far. Having the "LatLon" in the name
*and* 3D or XYZ hopefully clarifies that it's not some generic 3d thing. It
has latitudes and longitudes, which implies a sphere or ellipse surface
location.
> Come up with a comprehensive proposal for naming spatial modules and
> technologies
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-7202
> URL: https://issues.apache.org/jira/browse/LUCENE-7202
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/sandbox, modules/spatial, modules/spatial3d
> Affects Versions: master
> Reporter: Karl Wright
>
> There are three different spatial implementations circulating at the moment,
> and nobody seems happy with the naming of them. For each implementation
> strategy, we need both a module name and a descriptive technology name that
> we can use to distinguish one from the other. I would expect the following
> people to have an interest in this process: [~rcmuir], [~dsmiley],
> [~mikemccand], etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
