[
https://issues.apache.org/jira/browse/LUCENE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-7208.
----------------------------------
Resolution: Fixed
bq. I don't see it that way. Instead i see no argument for this getter, other
than your code is buggy and you should have multiple Automaton in your api
instead of these.
I think it's needlessly inflammatory to tell me my code is buggy, even though
no code yet has been written to do what I suggest. I hate the suspenseful
feeling I get seeing your communication to find out what your mood is.
Ironically what code has been written related to my inquiry is
MultiTiermHighlighting.java which you wrote, and could conceivably be rewritten
to benefit from what I'm talking about (at the expense of loosing connection to
the original query, but few highlighting apps need/care about that).
Any way, this is a design issue (not a bug). RunAutomaton's should be created
as late as possible over the Automaton if there is a question of possibly
needing the original Automaton. RunAutomaton needn't have a getter; I think it
shouldn't have the Automaton either if it's not going to have a getter. I'm
closing the issue.
> Expose Automaton getter on RunAutomaton
> ---------------------------------------
>
> Key: LUCENE-7208
> URL: https://issues.apache.org/jira/browse/LUCENE-7208
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/FSTs
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE_7208.patch
>
>
> RunAutomaton is (of course) built from an Automaton and it stores it on a
> field, package-private. It would be convenient to expose it via a getter.
> In fact CompiledAutomaton wants it.
> While we're at it, lets mark all the fields private and ensure that the only
> classes using its state (currently its 2 subclasses) use the getters that
> already exist for what they need. Those getters are already final so I don't
> expect a performance impact.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
