[
https://issues.apache.org/jira/browse/SOLR-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242965#comment-15242965
]
Christine Poerschke commented on SOLR-4941:
-------------------------------------------
[~dsmiley] and [~hossman] - thanks for including me on this. In SOLR-8621
myself and [~shaie] changed MergePolicy related config in
[SolrIndexConfig.java|https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java#L135]
where <useCompoundFile> is configured also.
The <useCompoundFile> setting name not reflecting exact use i.e. new segments
vs. segments created through merge, I agree that's not ideal and that the ref
guide at least mentioning it would be good. Though unless we can come up with a
very much clearer alternative name, would there be value in continuing to
mimic/match the Lucene setting name?
I agree, the 'initially uncompounded, then compounded-via-merge, then
uncompound-via-merge-since-too-large' lifecycle seems unusual as a default.
Making the default useCompoundFile value depend on the merge policy's
noCFSRatio value, would that not be confusing for users? (The XML paths in
solrconfig.xml are {{indexConfig/useCompoundFile}} and
{{indexConfig/mergePolicyFactory/int(noCFSRatio)}} respectively.)
How about changing the overall default (to useCompoundFile=true) and logging
WARNings for unusual combinations? Unusual combinations would be:
* {{useCompoundFile==false}} and {{noCFSRatio>0.0}}
* {{useCompoundFile==true}} and {{noCFSRatio==0.0}}
> useCompoundFile default has changed, simple config option no longer seems to
> work
> ---------------------------------------------------------------------------------
>
> Key: SOLR-4941
> URL: https://issues.apache.org/jira/browse/SOLR-4941
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Hoss Man
> Fix For: 4.4, master
>
> Attachments: SOLR-4941.patch, SOLR-4941.patch, infostream.txt
>
>
> Spin off of SOLR-4934. We should updated tests to ensure that the various
> ways of specifying useCompoundFile as well as the expected default are
> working properly after LUCENE-5038
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
