[ 
https://issues.apache.org/jira/browse/LUCENE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244469#comment-15244469
 ] 

Michael McCandless commented on LUCENE-7186:
--------------------------------------------

Thanks [~nknize], I think this is close!

Hmm I see some tests being deleted, e.g. 
{{TestGeoEncodingUtils.testEncodeDecodeRoundsDown}}?

Can you also fix {{GeoPointField.encodeLatLon}}:

{noformat}
    if ((result ^ 0xFFFFFFFFFFFFFFFFL) == 0) {
      return result & 0xC000000000000000L;
    }
{noformat}

to just use {{== 0xFFFFL}} instead?


> Add numerically stable morton encoding to GeoEncodingUtils
> ----------------------------------------------------------
>
>                 Key: LUCENE-7186
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7186
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-7186.patch, LUCENE-7186.patch, LUCENE-7186.patch, 
> LUCENE-7186.patch, LUCENE-7186.patch
>
>
> This is the follow on to LUCENE-7184.  It adds a numerically stable morton 
> encoding method to {{o.a.l.geo.GeoEncodingUtils}} that can be reused by 
> {{GeoPointField}} and a new {{GeoPointField}} based on {{Point}} encoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to