[
https://issues.apache.org/jira/browse/SOLR-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256407#comment-15256407
]
Erick Erickson commented on SOLR-8467:
--------------------------------------
I'll try to keep this up to date more often now that I've learned the 'git
stash' and 'git stash pop' trick.
I'll also clean up the nocommits and the like sometime Real Soon Now.
Do note that there's some nonsense in the test cases to randomly switch back
and forth between the Map and SolrParams c'tors in the classes. Mostly that's
there to make sure the translation I made in the c'tors from Map to Solrparams
gets exercised. That said, since there _are_ no more uses of the Map c'tor I
could easily argue that it's not required that we keep exercising the
deprecated (in this patch) Map c'tors, WDYT?
> CloudSolrStream and FacetStream should take a SolrParams object rather than a
> Map<String, String> to allow more complex Solr queries to be specified
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8467
> URL: https://issues.apache.org/jira/browse/SOLR-8467
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-8467.patch, SOLR-8467.patch, SOLR-8647.patch,
> SOLR-8647.patch
>
>
> Currently, it's impossible to, say, specify multiple "fq" clauses when using
> Streaming Aggregation due to the fact that the c'tors take a Map of params.
> Opening to discuss whether we should
> 1> deprecate the current c'tor
> and/or
> 2> add a c'tor that takes a SolrParams object instead.
> and/or
> 3> ???
> I don't see a clean way to go from a Map<String, String> to a
> (Modifiable)SolrParams, so existing code would need a significant change. I
> hacked together a PoC, just to see if I could make CloudSolrStream take a
> ModifiableSolrParams object instead and it passes tests, but it's so bad that
> I'm not going to even post it. There's _got_ to be a better way to do this,
> but at least it's possible....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
