[ 
https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259632#comment-15259632
 ] 

ASF subversion and git services commented on SOLR-9016:
-------------------------------------------------------

Commit 724b9f37a4e721a858caaa9a41104bd0380360bb in lucene-solr's branch 
refs/heads/branch_5x from [~anshum]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=724b9f3 ]

SOLR-9016: Fix SolrIdentifierValidator to not accept empty identifiers (port to 
5x)


> SolrIdentifierValidator accepts empty names
> -------------------------------------------
>
>                 Key: SOLR-9016
>                 URL: https://issues.apache.org/jira/browse/SOLR-9016
>             Project: Solr
>          Issue Type: Bug
>          Components: Server
>            Reporter: Shai Erera
>             Fix For: 5.5.1, 6.1, 6.0.1
>
>         Attachments: SOLR-9016.patch
>
>
> SolrIdentifierValidator accepts shard, collection, cores and alias names 
> following this pattern:
> {code}
> ^(?!\\-)[\\._A-Za-z0-9\\-]*$
> {code}
> This accepts an "empty" name. This is easily fixable by changing the {{\*}} 
> to {{+}}. However, it also accepts names such as {{..}}, {{,__---}} etc. Do 
> we not want to require collection names to have a letter/digit identifier in 
> them? Something like the following pattern:
> {code}
> ^(\\.)?[a-zA-Z0-9]+[\\._\\-a-zA-Z0-9]*$
> {code}
> That pattern requires the name to start with an optional {{.}} followed by a 
> series of letters/digits followed by the rest of the allowed characters.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to