[ 
https://issues.apache.org/jira/browse/LUCENE-3001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012644#comment-13012644
 ] 

Uwe Schindler commented on LUCENE-3001:
---------------------------------------

Hi, sorry I saw the commit but this is not in line with current Lucene:

- Lucene uses Numeric* not Trie* (trie is only used in solr, historically 
because there were other numeric fields before)
- This helper is somehow a ugly replacement for NumericField, the encoding 
should be in NumericField itsself, maybe using a "binary stored" type in its 
ctor.

So please revert this and put it into a Solr util! This commit was much too 
fast and without discussion.

> Add TrieFieldHelper lucene so we can write solr compatible Trie* fields w/o 
> solr dependency
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3001
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3001
>             Project: Lucene - Java
>          Issue Type: New Feature
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: LUCENE-3001-TrieFieldHelper.patch
>
>
> The solr support for numeric fields writes the stored value as binary vs the 
> lucene NumericField
> We should move this logic to a helper class in lucene core so that libraries 
> that do not depend on solr can write TrieFields that solr can read.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to