[
https://issues.apache.org/jira/browse/SOLR-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270950#comment-15270950
]
ASF GitHub Bot commented on SOLR-8323:
--------------------------------------
Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216922168
> One thing I noticed in writing this is that it's uncertain whether you'll
miss any states or not
Unless I'm misunderstanding you, this is just how ZK works, though. A
watcher firing just means that there has been at least one change to the
watched node in the space of the last tick. So we wouldn't be able to
guarantee that the CollectionStateWatcher is notified of every change.
If we're making CSW public again, I don't think the queueing implementation
you have there will work? An executor seems to be the most straightforward way
of doing things here. Although, thinking more about that, we already have a
separate executor for watchers, don't we? So this may just be overthinking
things.
> Add CollectionWatcher API to ZkStateReader
> ------------------------------------------
>
> Key: SOLR-8323
> URL: https://issues.apache.org/jira/browse/SOLR-8323
> Project: Solr
> Issue Type: Improvement
> Affects Versions: master
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Attachments: SOLR-8323.patch, SOLR-8323.patch, SOLR-8323.patch,
> SOLR-8323.patch
>
>
> An API to watch for changes to collection state would be a generally useful
> thing, both internally and for client use.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
