[ 
https://issues.apache.org/jira/browse/SOLR-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271319#comment-15271319
 ] 

Hrishikesh Gadre commented on SOLR-9055:
----------------------------------------

bq. Yes I think it is possible to use Lucene Directory implementation without 
requiring a different "Repository" interface. Currently we don't have Directory 
implementation available for S3 though. Should we do that?

OK. I will update the patch to use Directory interface (and remove Repository 
interface). But still I would like to understand how should we proceed with 
integration with different file-systems? It occurs to me that the 
"DirectoryFactory" configuration in solrconfig.xml can be exposed at a higher 
level so that it would be useful for both both index management and 
backup/restore. e.g. consider how HDFS configuration is done today,
https://github.com/cloudera/lucene-solr/blob/25d722e35238cca776abbe3a621e0c5b733e762d/cloudera/solrconfig.xml#L119

If this is exposed via a separate "Repository" API, then solrconfig.xml can 
also refer to it via user-configurable "name". (Please note that some care 
needs to be taken to allow "block-cache" to be configured selectively as 
backup/restore solution does not need it). This way users can register multiple 
repositories (e.g. local file-system, HDFS etc.) and choose one of index 
management and other for backup/restore without duplicate configuration (e.g. 
one in solrconfig.xml and other as part of "Repository" API).

It seems like a major change though it is a "correct" solution. So any feedback 
on this would be great.


> Make collection backup/restore extensible
> -----------------------------------------
>
>                 Key: SOLR-9055
>                 URL: https://issues.apache.org/jira/browse/SOLR-9055
>             Project: Solr
>          Issue Type: Task
>            Reporter: Hrishikesh Gadre
>            Assignee: Mark Miller
>         Attachments: SOLR-9055.patch, SOLR-9055.patch
>
>
> SOLR-5750 implemented backup/restore API for Solr. This JIRA is to track the 
> code cleanup/refactoring. Specifically following improvements should be made,
> - Add Solr/Lucene version to check the compatibility between the backup 
> version and the version of Solr on which it is being restored.
> - Add a backup implementation version to check the compatibility between the 
> "restore" implementation and backup format.
> - Introduce a Strategy interface to define how the Solr index data is backed 
> up (e.g. using file copy approach).
> - Introduce a Repository interface to define the file-system used to store 
> the backup data. (currently works only with local file system but can be 
> extended). This should be enhanced to introduce support for "registering" 
> repositories (e.g. HDFS, S3 etc.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to