[ 
https://issues.apache.org/jira/browse/SOLR-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273283#comment-15273283
 ] 

Dennis Gove edited comment on SOLR-9058 at 5/5/16 11:09 PM:
------------------------------------------------------------

This patch fixes up both hashJoin and outerHashJoin and adds tests for the 
scenario to both. 

The approach taken is to have a left and right list of fields to hash on. 
During construction it checks for an = in the field and if found will split 
into a left and right side field name. If not found then it uses that single 
field name for both the left and right side. It then uses those lists when 
reading tuples from the stream.

[~Osthold], good catch on this one and thank you for the test showing the 
failure (I swiped that and included it in the test case).


was (Author: dpgove):
This patch fixes up both hashJoin and outerHashJoin and adds tests for the 
scenario to both. 

The approach taken is to have a left and right list of fields to hash on. 
During construction it checks for an = in the field and if found will split 
into a left and right side field name. If not found then it uses that single 
field name for both the left and right side. It then uses those lists when 
reading tuples from the stream.

[~Osthold], good catch on this one and thank you for the test showing the 
failure (I swiped that and included it in the test cast).

> hashJoin does not work when "on" maps fields with "="
> -----------------------------------------------------
>
>                 Key: SOLR-9058
>                 URL: https://issues.apache.org/jira/browse/SOLR-9058
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Stephan Osthold
>            Assignee: Dennis Gove
>            Priority: Minor
>         Attachments: SOLR-9058.patch
>
>
> hashJoin does not work when "on" maps fields with "="
> eg.
> hashJoin(
>  ...
>  on="field1=field2"
> )
> See link for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to