[ 
https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276436#comment-15276436
 ] 

Yonik Seeley edited comment on SOLR-7115 at 5/9/16 2:40 PM:
------------------------------------------------------------

Not opening a new searcher breaks our invariants after that point (breaks RTG, 
atomic updates, version checking for things like update reorder checks, etc).
I wonder if we can we can guarantee that nothing is in-flight that would be 
affected?



was (Author: [email protected]):
Not opening a new searcher breaks our invariants after that point (breaks RTG, 
atomic updates, version checking for things like update reorder checks, etc).
I wondwe if we can we can guarantee that nothing is in-flight that would be 
affected?


> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
>                 Key: SOLR-7115
>                 URL: https://issues.apache.org/jira/browse/SOLR-7115
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>
> I've seen this happen on YourKit and in various tests - especially since 
> adding resource release tracking to the log objects. Now I've got a test that 
> catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it 
> because we are going to overwrite prevTlog with a new log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to