[
https://issues.apache.org/jira/browse/SOLR-9107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-9107:
---------------------------
Attachment: SOLR-9107.patch
i've tweaked the syntax a bit from my original comment ({{@RandomizeSSL(0.0)}}
instead of {{@RandomizeSSL(false)}} so it plays more nicely with things like
{{@RandomizeSSL(1.0)}}) but here's a patch that is pretty close to what i
described before.
you can still use {{@SuppressSSL}} of course, or provide a single double value
to control the odds of both SSL and clientAuth -- ie: {{@RandomizeSSL(0.5)}}
for 50% chance (clientAuth still calculated independently) or go whole hog and
say things like "I want SSL to always be used, but clientAuth should never be
used" via {{@RandomizeSSL(ssl=1.0,clientAuth=0.0)}}
This also increases the "effective odds" of both SSL and clientAuth based on
test.nightly and the value of the test.multiplier (starting with the
"configured odds")
at present, the "sensible default" when no odds are explicitly configured is
still 20% of the time (which can wind up being higher with nightly/multiplier),
but i think we could easily decrease that default to 10% or even 5% (to speed
up typical test runs) if we move forward with adding this annotation (using
high configured values) to some of the more critical (and short) cloud tests
that we really want to use SSL frequently. LIkewise, some of the existing
{{@SuppressSSL}} tests could probably be switched to something like
{{@RandomizeSSL(0.01)}} so they can still get tested with SSL occasionally
[[email protected]] -- what do you think?
> add annotation for more fine grained control of SSL per test-class
> ------------------------------------------------------------------
>
> Key: SOLR-9107
> URL: https://issues.apache.org/jira/browse/SOLR-9107
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Fix For: 4.9, 6.0
>
> Attachments: SOLR-9107.patch
>
>
> Spinning off this idea from my earlier comment in SOLR-5776...
> ----
> At some point in the future, after all this soaks, we should consider
> increasing the odds of using SSL – perhaps even add a new annotation (or
> replace @SupressSSL) with a param to help control the odds of using SSL /
> clientAuth on a per-class basis, ie...
> {noformat}
> @UseSSL(false) // same as @SupressSSL
> @UseSSL() // same as default if no annotation: SolrTestCaseJ4 picks SSL /
> clientAuth using LuceneTestCase.rarely
> @UseSSL(ssl=0.75,clientAuth=0.25) // fine control of odds of using ssl &
> clientauth
> {noformat}
> ...some tests, like TestSSLRandomization should ideally have much higher odds
> of using SSL then other tests, and if we had an easy way to say "these
> handful of simple cloud tests should use SSL very frequently" then it
> wouldn't matter so much if the odds of other really 'expensive' tests only
> use SSL once in a blue moon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
