[
https://issues.apache.org/jira/browse/SOLR-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285083#comment-15285083
]
Shalin Shekhar Mangar commented on SOLR-9117:
---------------------------------------------
Thanks Jessica! I don't see why/how createdCores is useful so +1 on removing it.
I'll commit this in a day if no one objects to it.
> Leaking the first SolrCore after reload
> ---------------------------------------
>
> Key: SOLR-9117
> URL: https://issues.apache.org/jira/browse/SOLR-9117
> Project: Solr
> Issue Type: Bug
> Reporter: Jessica Cheng Mallet
> Labels: core, leak
> Attachments: SOLR-9117.patch
>
>
> When a SolrCore for a particular index is created for the first time, it's
> added to the SolrCores#createdCores map. However, this map doesn't get
> updated when this core is reloaded, leading to the first SolrCore being
> leaked.
> Taking a look at how createdCores is used, it seems like it doesn't serve any
> purpose (its only read is in SolrCores#getAllCoreNames, which includes
> entries from SolrCores.cores anyway), so I'm proposing a patch to remove the
> createdCores map completely. However, if someone else knows that createdCores
> exist for a reason, I'll be happy to change the fix to updating the
> createdCores map when reload is called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
