[ 
https://issues.apache.org/jira/browse/SOLR-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286575#comment-15286575
 ] 

Steve Rowe commented on SOLR-9121:
----------------------------------

Thanks Christine, I'm trying to figure out if there is a simpler way to pass 
through the {{ivysettings.xml}} property, the root of the problem being the 
fact that this property isn't visible from LibVersionsCheckTask.

I agree the names are not great.  The point of SOLR-9109 is to allow the user 
to supply a custom ivysettings.xml, and ideally they shouldn't have to know 
that the build uses a nesting strategy to set Ivy variables for dependencies' 
versions.

At a minimum, if we end up going with your patch, the name of the passed-in 
nested ivy settings file shouldn't include the word "default", since when the 
user supplies a custom one, it won't be that.

> ant precommit fails on ant check-lib-versions
> ---------------------------------------------
>
>                 Key: SOLR-9121
>                 URL: https://issues.apache.org/jira/browse/SOLR-9121
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>         Attachments: SOLR-9121.patch
>
>
> e.g.  http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16766/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to